Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: chrome/browser/tab_contents/tab_contents.cc

Issue 147145: Fix: Certain redirections remove sites from the history... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.h ('k') | chrome/tools/profiles/generate_profile.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/tab_contents.cc
===================================================================
--- chrome/browser/tab_contents/tab_contents.cc (revision 19705)
+++ chrome/browser/tab_contents/tab_contents.cc (working copy)
@@ -1246,7 +1246,7 @@
// URLs, we use a data: URL as the real value. We actually want to save
// the about: URL to the history db and keep the data: URL hidden. This is
// what the TabContents' URL getter does.
- UpdateHistoryForNavigation(GetURL(), params);
+ UpdateHistoryForNavigation(GetURL(), details, params);
}
// Notify the password manager of the navigation or form submit.
@@ -1318,6 +1318,7 @@
void TabContents::UpdateHistoryForNavigation(
const GURL& display_url,
+ const NavigationController::LoadCommittedDetails& details,
const ViewHostMsg_FrameNavigate_Params& params) {
if (profile()->IsOffTheRecord())
return;
@@ -1337,10 +1338,11 @@
if (!redirects.empty())
redirects.back() = display_url;
hs->AddPage(display_url, this, params.page_id, params.referrer,
- params.transition, redirects);
+ params.transition, redirects, details.did_replace_entry);
} else {
hs->AddPage(params.url, this, params.page_id, params.referrer,
- params.transition, params.redirects);
+ params.transition, params.redirects,
+ details.did_replace_entry);
}
}
}
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.h ('k') | chrome/tools/profiles/generate_profile.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698