Fix: Certain redirections remove sites from the history...

chrome/browser/tab_contents/navigation_controller.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_TAB_CONTENTS_NAVIGATION_CONTROLLER_H_
 #define CHROME_BROWSER_TAB_CONTENTS_NAVIGATION_CONTROLLER_H_
 
 #include <map>
 
 #include "build/build_config.h"
@@ skipping 38 matching lines @@
 
   // Provides the details for a NOTIFY_NAV_ENTRY_COMMITTED notification.
   // TODO(brettw) this mostly duplicates ProvisionalLoadDetails, it would be
   // nice to unify these somehow.
   struct LoadCommittedDetails {
     // By default, the entry will be filled according to a new main frame
     // navigation.
     LoadCommittedDetails()
         : entry(NULL),
           is_auto(false),
+          did_replace_entry(false),
           is_in_page(false),
           is_main_frame(true) {
     }
 
     // The committed entry. This will be the active entry in the controller.
     NavigationEntry* entry;
 
     // The type of navigation that just occurred. Note that not all types of
     // navigations in the enum are valid here, since some of them don't actually
     // cause a "commit" and won't generate this notification.
     NavigationType::Type type;
 
     // The index of the previously committed navigation entry. This will be -1
     // if there are no previous entries.
     int previous_entry_index;
 
     // The previous URL that the user was on. This may be empty if none.
     GURL previous_url;
 
     // True when this load was non-user initated. This corresponds to a
     // a NavigationGestureAuto call from WebKit (see webview_delegate.h).
     // We also count reloads and meta-refreshes as "auto" to account for the
     // fact that WebKit doesn't always set the user gesture properly in these
     // cases (see bug 1051891).
     bool is_auto;
 
+    // True if the committed entry has replaced the exisiting one.
+    // A non-user initiated redierct causes such replacement.
+    // This is somewhat similiar to is_auto, but not exactly the same.
+    bool did_replace_entry;
+
     // True if the navigation was in-page. This means that the active entry's
     // URL and the |previous_url| are the same except for reference fragments.
     bool is_in_page;
 
     // True when the main frame was navigated. False means the navigation was a
     // sub-frame.
     bool is_main_frame;
 
     // Whether the content of this frame has been altered/blocked because it was
     // unsafe.
@@ skipping 295 matching lines @@
   void LoadEntry(NavigationEntry* entry);
 
   // Handlers for the different types of navigation types. They will actually
   // handle the navigations corresponding to the different NavClasses above.
   // They will NOT broadcast the commit notification, that should be handled by
   // the caller.
   //
   // RendererDidNavigateAutoSubframe is special, it may not actually change
   // anything if some random subframe is loaded. It will return true if anything
   // changed, or false if not.
+  //
+  // The functions taking |did_replace_entry| will fill into the given variable
+  // whether the last entry has been replaced or not.
+  // See LoadCommittedDetails.did_replace_entry.
   void RendererDidNavigateToNewPage(
-      const ViewHostMsg_FrameNavigate_Params& params);
+      const ViewHostMsg_FrameNavigate_Params& params, bool* did_replace_entry);
   void RendererDidNavigateToExistingPage(
       const ViewHostMsg_FrameNavigate_Params& params);
   void RendererDidNavigateToSamePage(
       const ViewHostMsg_FrameNavigate_Params& params);
   void RendererDidNavigateInPage(
-      const ViewHostMsg_FrameNavigate_Params& params);
+      const ViewHostMsg_FrameNavigate_Params& params, bool* did_replace_entry);
   void RendererDidNavigateNewSubframe(
       const ViewHostMsg_FrameNavigate_Params& params);
   bool RendererDidNavigateAutoSubframe(
       const ViewHostMsg_FrameNavigate_Params& params);
 
   // Actually issues the navigation held in pending_entry.
   void NavigateToPendingEntry(bool reload);
 
   // Allows the derived class to issue notifications that a load has been
   // committed. This will fill in the active entry to the details structure.
@@ skipping 97 matching lines @@
   // when testing.
   static bool check_for_repost_;
 
   // The maximum number of entries that a navigation controller can store.
   static size_t max_entry_count_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationController);
 };
 
 #endif  // CHROME_BROWSER_TAB_CONTENTS_NAVIGATION_CONTROLLER_H_