Fix: Certain redirections remove sites from the history...

chrome/browser/history/history.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The history system runs on a background thread so that potentially slow
 // database operations don't delay the browser. This backend processing is
 // represented by HistoryBackend. The HistoryService's job is to dispatch to
 // that thread.
 //
 // Main thread                       History thread
@@ skipping 235 matching lines @@
 void HistoryService::SetOnBackendDestroyTask(Task* task) {
   ScheduleAndForget(PRIORITY_NORMAL, &HistoryBackend::SetOnBackendDestroyTask,
                     MessageLoop::current(), task);
 }
 
 void HistoryService::AddPage(const GURL& url,
                              const void* id_scope,
                              int32 page_id,
                              const GURL& referrer,
                              PageTransition::Type transition,
-                             const RedirectList& redirects) {
-  AddPage(url, Time::Now(), id_scope, page_id, referrer, transition, redirects);
+                             const RedirectList& redirects,
+                             bool did_replace_entry) {
+  AddPage(url, Time::Now(), id_scope, page_id, referrer, transition, redirects,
+          did_replace_entry);
 }
 
 void HistoryService::AddPage(const GURL& url,
                              Time time,
                              const void* id_scope,
                              int32 page_id,
                              const GURL& referrer,
                              PageTransition::Type transition,
-                             const RedirectList& redirects) {
+                             const RedirectList& redirects,
+                             bool did_replace_entry) {
   DCHECK(history_backend_) << "History service being called after cleanup";
 
   // Filter out unwanted URLs. We don't add auto-subframe URLs. They are a
   // large part of history (think iframes for ads) and we never display them in
   // history UI. We will still add manual subframes, which are ones the user
   // has clicked on to get.
   if (!CanAddURL(url) || PageTransition::StripQualifier(transition) ==
                          PageTransition::AUTO_SUBFRAME)
     return;
 
   // Add link & all redirects to visited link list.
   VisitedLinkMaster* visited_links;
   if (profile_ && (visited_links = profile_->GetVisitedLinkMaster())) {
     visited_links->AddURL(url);
 
     if (!redirects.empty()) {
       // We should not be asked to add a page in the middle of a redirect chain.
       DCHECK(redirects[redirects.size() - 1] == url);
 
       // We need the !redirects.empty() condition above since size_t is unsigned
       // and will wrap around when we subtract one from a 0 size.
       for (size_t i = 0; i < redirects.size() - 1; i++)
         visited_links->AddURL(redirects[i]);
     }
   }
 
   scoped_refptr<history::HistoryAddPageArgs> request(
       new history::HistoryAddPageArgs(url, time, id_scope, page_id,
-                                      referrer, redirects, transition));
+                                      referrer, redirects, transition,
+                                      did_replace_entry));
   ScheduleAndForget(PRIORITY_NORMAL, &HistoryBackend::AddPage, request);
 }
 
 void HistoryService::SetPageTitle(const GURL& url,
                                   const std::wstring& title) {
   ScheduleAndForget(PRIORITY_NORMAL, &HistoryBackend::SetPageTitle, url, title);
 }
 
 void HistoryService::AddPageWithDetails(const GURL& url,
                                         const std::wstring& title,
@@ skipping 358 matching lines @@
   NotificationService::current()->Notify(type, source, det);
 }
 
 void HistoryService::OnDBLoaded() {
   LOG(INFO) << "History backend finished loading";
   backend_loaded_ = true;
   NotificationService::current()->Notify(NotificationType::HISTORY_LOADED,
                                          Source<Profile>(profile_),
                                          Details<HistoryService>(this));
 }