X64 implementation: VisitLoop and StackCheck

X64 implementation: VisitLoop and StackCheck

Committed: http://code.google.com/p/v8/source/detail?r=2270

[Lasse Reichstein, 2009-06-25 09:40:21]

LGTM

http://codereview.chromium.org/147143/diff/1/2
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/147143/diff/1/2#newcode691
Line 691: void CodeGenerator::VisitLoopStatement(LoopStatement* node) {
Is there anything X64 specific about this function?

http://codereview.chromium.org/147143/diff/1/2#newcode710
Line 710: }
Would it be worth checking for a literal number? Some people undoubtedly write
"while(1){...}".

[William Hesse, 2009-06-25 10:39:33]

http://codereview.chromium.org/147143/diff/1/2
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/147143/diff/1/2#newcode691
Line 691: void CodeGenerator::VisitLoopStatement(LoopStatement* node) {
On 2009/06/25 09:40:21, Lasse Reichstein wrote:
> Is there anything X64 specific about this function?

No, there is not.  There may be differences with the ARM version, but if not, it
could be moved to codegen.cc.

http://codereview.chromium.org/147143/diff/1/2#newcode710
Line 710: }
On 2009/06/25 09:40:21, Lasse Reichstein wrote:
> Would it be worth checking for a literal number? Some people undoubtedly write
> "while(1){...}".

I would suggest adding a function to Literal that checks this.