Issue 147142: Make sure that message reporting works when the builtin string and...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147142: Make sure that message reporting works when the builtin string and... (Closed)

Created:
11 years, 6 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Make sure that message reporting works when the builtin string and array functions are overwritten. Committed: http://code.google.com/p/v8/source/detail?r=2269

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -21 lines)			Patch
M	src/messages.js	View	7 chunks	+10 lines, -18 lines	0 comments	Download
A	test/message/overwritten-builtins.js	View	1 chunk	+31 lines, -0 lines	0 comments	Download
A	test/message/overwritten-builtins.out	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	test/mjsunit/debug-sourceinfo.js	View	2 chunks	+9 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Kasper Lund

11 years, 6 months ago (2009-06-25 08:39:46 UTC) #2

LGTM. Nice to see that you took the time to write a simple test case.