Issue 147125: Support running http layout tests for workers in UI test framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147125: Support running http layout tests for workers in UI test framework. (Closed)

Created:
11 years, 6 months ago by jianli

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain, Dmitry Titov

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Support running http layout tests for workers in UI test framework. BUG=none TEST=This is a UI test. Nicolas, could you please review DEPS? I added a couple of new lines to DEPS in order to fetch a copy the following directory into UI test data directory: LayoutTests/http/tests/resources LayoutTests/http/tests/workers LayoutTests/http/tests/xmlhttprequest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19502

Patch Set 1 #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -35 lines)			Patch
	M	DEPS	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/worker/worker_uitest.cc	View		11 chunks	+106 lines, -35 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dmitry Titov

11 years, 6 months ago (2009-06-25 18:09:12 UTC) #3

LGTM with small notes

http://codereview.chromium.org/147125/diff/1/3
File chrome/worker/worker_uitest.cc (left):

http://codereview.chromium.org/147125/diff/1/3#oldcode294
Line 294: TEST_F(WorkerTest, TestHttpServer) {
either leave this test (as a test for StartHttpServer itself) or remove 2 files
that it is using (test_http_server_up.html and worker_common.php). It might be
ok to just leave this test here to test purely Start.StopHttpServer.

http://codereview.chromium.org/147125/diff/1/3
File chrome/worker/worker_uitest.cc (right):

http://codereview.chromium.org/147125/diff/1/3#newcode42
Line 42: bool for_http);
bool vars are usually named using "is_foo" pattern. "is_http_test"?

Expand Messages | Collapse Messages