Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1778)

Unified Diff: chrome/renderer/extensions/event_bindings.cc

Issue 147124: Add notifications for when V8Proxy creates or destroys a V8 Context. (Closed)
Patch Set: roll deps Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/event_bindings.h ('k') | chrome/renderer/render_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/event_bindings.cc
diff --git a/chrome/renderer/extensions/event_bindings.cc b/chrome/renderer/extensions/event_bindings.cc
index 576beba4c8a37c58d55148d9c053371a695047e7..7c988e2be7a40f10eb036f75ff2a93176e8eb331 100644
--- a/chrome/renderer/extensions/event_bindings.cc
+++ b/chrome/renderer/extensions/event_bindings.cc
@@ -12,6 +12,7 @@
#include "chrome/renderer/js_only_v8_extensions.h"
#include "chrome/renderer/render_thread.h"
#include "grit/renderer_resources.h"
+#include "webkit/glue/webframe.h"
namespace {
@@ -164,6 +165,22 @@ void EventBindings::SetRenderThread(RenderThreadBase* thread) {
render_thread = thread;
}
+// static
+void EventBindings::HandleContextCreated(WebFrame* frame) {
+ v8::HandleScope handle_scope;
+ v8::Local<v8::Context> context = frame->GetScriptContext();
+ DCHECK(!context.IsEmpty());
+ // TODO(mpcomplete): register it
+}
+
+// static
+void EventBindings::HandleContextDestroyed(WebFrame* frame) {
+ v8::HandleScope handle_scope;
+ v8::Local<v8::Context> context = frame->GetScriptContext();
+ DCHECK(!context.IsEmpty());
+ // TODO(mpcomplete): unregister it, dispatch event
+}
+
void EventBindings::CallFunction(const std::string& function_name,
int argc, v8::Handle<v8::Value>* argv) {
for (ContextList::iterator it = GetRegisteredContexts().begin();
« no previous file with comments | « chrome/renderer/extensions/event_bindings.h ('k') | chrome/renderer/render_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698