Make more things possible with mock sockets:...

Make more things possible with mock sockets:

- check connection state in mock read and write
- make possible simulating short reads in DynamicMockSocket

TEST=none

http://crbug.com/15259

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19222

[wtc, 2009-06-25 00:21:55]

LGTM.

http://codereview.chromium.org/147117/diff/1/2
File net/socket/socket_test_util.cc (right):

http://codereview.chromium.org/147117/diff/1/2#newcode308
Line 308: MockRead StaticMockSocket::GetNextRead() {
This will return a copy of MockRead.  Is that intentional?

http://codereview.chromium.org/147117/diff/1/3
File net/socket/socket_test_util.h (right):

http://codereview.chromium.org/147117/diff/1/3#newcode70
Line 70: MockSocket() {
Nit: put {} on the same line, to be consistent with the
destructor below.

http://codereview.chromium.org/147117/diff/1/3#newcode122
Line 122: int short_read_limit() const { return short_read_limit_; }
Nit: you can just name the methods and member "read_limit".
Up to you...

http://codereview.chromium.org/147117/diff/1/3#newcode135
Line 135: // Max number of bytes we will return to be read at a time. 0 means no
limit.
Nit: "return to be read" => "return from Read" or just "read"

[eroman, 2009-06-25 01:21:04]

lgtm

[Paweł Hajdan Jr., 2009-06-25 02:43:28]

> http://codereview.chromium.org/147117/diff/1/2#newcode308
> Line 308: MockRead StaticMockSocket::GetNextRead() {
> This will return a copy of MockRead.  Is that intentional?

Yes. This way it's easier to implement mocking short reads. I can return a copy
of MockRead and modify the stored copy.

> http://codereview.chromium.org/147117/diff/1/3
> File net/socket/socket_test_util.h (right):
> 
> http://codereview.chromium.org/147117/diff/1/3#newcode70
> Line 70: MockSocket() {
> Nit: put {} on the same line, to be consistent with the
> destructor below.

Done.

> http://codereview.chromium.org/147117/diff/1/3#newcode135
> Line 135: // Max number of bytes we will return to be read at a time. 0 means
no
> limit.
> Nit: "return to be read" => "return from Read" or just "read"

Done.