This CL contains the the changes needed to build...

This CL contains the the changes needed to build
an externs file for the JSCompiler as well as
the code to build a compiled verison of the o3djs
sample libs.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19659

[gman, 2009-06-24 10:45:36]

A couple more things

1) I'm not sure what the policy is for checking in the JSCompiler. It's just the
.jar file.

2) The Mac version will not build unless the mac is set to use JVM 1.6. That can
be set using the appp Applications/Utilities/Java Preferences

3) I'm not sure what I have to change in DEPS to make this change get the other
2 changes needed to make this work. Those are the patch to jsdoctoolkit and a
new version of nixysa.

[gman, 2009-06-24 10:52:15]

Oh, and one more thing.

We need to figure out what to do with the compiled o3djs libs. Once we actually
turn this on in the build it needs to always happen because it catches tons of
bugs in both the IDL files and the o3djs files.

But, we also need to check in the output OR at least have the "push a release
script" check in an built version of the output so that we can put a link "get
the compiled version here"

The question is where.

On top of that what we also need to do is both check a version of that into
subversion and also change it so the samples on
http://code.google.com/apis/o3d/docs/samplesdirectory.html need to be checked in
in such a way that;

(a) they are not served from trunk. Trunk often requires the latest plugin and
so will break as we update the samples but don't push a new version of the
plugin to match.

(b) samples/o3djs/base.js used by the live samples needs to be a copy to the
compiled o3djs libs. This will make all the samples load up to 30seconds faster.

[Greg Spencer, 2009-06-25 01:23:20]

LGTM

http://codereview.chromium.org/147079/diff/1/8
File documentation/build.scons (right):

http://codereview.chromium.org/147079/diff/1/8#newcode59
Line 59: print "idltarget:", t
Did you want these debug outputs in the real build?  Seems kind of verbose for
everyday use...

http://codereview.chromium.org/147079/diff/1/7
File utils/build.scons (right):

http://codereview.chromium.org/147079/diff/1/7#newcode40
Line 40: 'cross/structured_writer.cc',
Where is structured_writer.cc?  I don't see it added in this CL...

[gman, 2009-06-30 21:21:04]

Here's an updated version. This one actually stops calling doxygen and calls the
new system. I thought you should take a look before I submit.

I haven't done anything for GYP. I was kind of hoping you could help me with
that in another CL but we can do it in this CL if we need to.

[Greg Spencer, 2009-06-30 21:43:00]

LGTM