Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: src/runtime.js

Issue 147075: Allocate arguments object on-demand instead of at function entry.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 throw %MakeTypeError('called_non_callable', [typeof callee]); 384 throw %MakeTypeError('called_non_callable', [typeof callee]);
385 } 385 }
386 386
387 var parameters = %NewArguments(delegate); 387 var parameters = %NewArguments(delegate);
388 return delegate.apply(callee, parameters); 388 return delegate.apply(callee, parameters);
389 } 389 }
390 390
391 391
392 function APPLY_PREPARE(args) { 392 function APPLY_PREPARE(args) {
393 var length; 393 var length;
394 // First check whether length is a positive Smi and args is an array. This is the 394 // First check whether length is a positive Smi and args is an
395 // fast case. If this fails, we do the slow case that takes care of more even tualities 395 // array. This is the fast case. If this fails, we do the slow case
396 // that takes care of more eventualities.
396 if (%_IsArray(args)) { 397 if (%_IsArray(args)) {
397 length = args.length; 398 length = args.length;
398 if (%_IsSmi(length) && length >= 0 && length < 0x800000 && IS_FUNCTION(this) ) { 399 if (%_IsSmi(length) && length >= 0 && length < 0x800000 && IS_FUNCTION(this) ) {
399 return length; 400 return length;
400 } 401 }
401 } 402 }
402 403
403 length = (args == null) ? 0 : %ToUint32(args.length); 404 length = (args == null) ? 0 : %ToUint32(args.length);
404 405
405 // We can handle any number of apply arguments if the stack is 406 // We can handle any number of apply arguments if the stack is
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
578 throw %MakeTypeError('cannot_convert_to_primitive', []); 579 throw %MakeTypeError('cannot_convert_to_primitive', []);
579 } 580 }
580 581
581 582
582 // NOTE: Setting the prototype for Array must take place as early as 583 // NOTE: Setting the prototype for Array must take place as early as
583 // possible due to code generation for array literals. When 584 // possible due to code generation for array literals. When
584 // generating code for a array literal a boilerplate array is created 585 // generating code for a array literal a boilerplate array is created
585 // that is cloned when running the code. It is essiential that the 586 // that is cloned when running the code. It is essiential that the
586 // boilerplate gets the right prototype. 587 // boilerplate gets the right prototype.
587 %FunctionSetPrototype($Array, new $Array(0)); 588 %FunctionSetPrototype($Array, new $Array(0));
OLDNEW
« src/ia32/codegen-ia32.cc ('K') | « src/parser.cc ('k') | src/scopes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698