Issue 147074: Merging r18584 into chrome/browser/views/tab_contents/tab_contents_view_win.c...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147074: Merging r18584 into chrome/browser/views/tab_contents/tab_contents_view_win.c... (Closed)

Created:
11 years, 6 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), Mark Larson

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Merging r18584 into chrome/browser/views/tab_contents/tab_contents_view_win.cc. My last patch (http://src.chromium.org/viewvc/chrome?view=rev&revision=18584) should have been for chrome/browser/views/tab_contents/tab_contents_view_win.cc, not for chrome/browser/tab_contents/tab_contents_view_win.cc since the latter had been deleted (http://src.chromium.org/viewvc/chrome?view=rev&revision=18368). I've confirmed that no patch other than mine is submitted to the old file: http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc?view=log BUG=12290 TEST=See http://codereview.chromium.org/125111 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19194

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -619 lines)			Patch
	D	chrome/browser/tab_contents/tab_contents_view_win.cc	View		1 chunk	+0 lines, -617 lines	0 comments	Download
	M	chrome/browser/views/tab_contents/tab_contents_view_win.cc	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Yusuke Sato

Scott, I apologize for bothering you, but can you review this again?

11 years, 6 months ago (2009-06-24 06:56:47 UTC) #1

Yusuke Sato

11 years, 6 months ago (2009-06-24 23:12:06 UTC) #3

On 2009/06/24 15:39:33, sky wrote:
> LGTM

Thanks, submitted.