Issue 147071: Make the options menu keyboard navigatable. Hide the menu when the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147071: Make the options menu keyboard navigatable. Hide the menu when the... (Closed)

Created:
11 years, 6 months ago by arv (Not doing code reviews)

Modified:
9 years, 4 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), Miranda Callahan

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make the options menu keyboard navigatable. Hide the menu when the button is clicked a second time. BUG=14959, 15067 TEST=Tab to the options button. Try pressing the down arrow, up arrow or enter. These should show the menu. Try pressing esc to hide the menu. Try pressing enter to execute the item. Try opening the menu, both using the mouse and keyboard and make sure that it is hidden as expected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19141

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+160 lines, -36 lines)			Patch
M	chrome/browser/resources/new_new_tab.css	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/new_new_tab.js	View	1 chunk	+158 lines, -31 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

I had to manually keep track of the selected index instead of relying on :hover ...

11 years, 6 months ago (2009-06-24 02:45:18 UTC) #1

Glen Murphy

11 years, 6 months ago (2009-06-24 17:04:03 UTC) #2

LG

http://codereview.chromium.org/147071/diff/1/4
File chrome/browser/resources/new_new_tab.js (right):

http://codereview.chromium.org/147071/diff/1/4#newcode673
Line 673: var optionMenu = {
Can you add a brief description?

Expand Messages | Collapse Messages