Issue 147063: Order posix file listings by type as well as name....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147063: Order posix file listings by type as well as name.... (Closed)

Created:
11 years, 6 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Dean McNamee, Yuzo

CC:
chromium-reviews_googlegroups.com, John Grabowski

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Order posix file listings by type as well as name. http://crbug.com/12812 TEST=go to /, see that directories are sorted before other files. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19100

Patch Set 3 : pass unit tests #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -6 lines)			Patch
	M	base/file_util_posix.cc	View	1	2 chunks	+25 lines, -4 lines	0 comments	Download
	M	base/file_util_unittest.cc	View		2 chunks	+19 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yuzo

LGTM http://codereview.chromium.org/147063/diff/1/2 File base/file_util_posix.cc (right): http://codereview.chromium.org/147063/diff/1/2#newcode582 Line 582: bool b_is_dir = IsDirectory(*b); Nit: "const bool" ...

11 years, 6 months ago (2009-06-24 01:04:47 UTC) #2

done and done

Expand Messages | Collapse Messages

Issue 147063: Order posix file listings by type as well as name.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : comments #

Patch Set 3 : pass unit tests #

Messages