Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 147051: Clean up a few startup and shutdown dependencies which should fix some of the... (Closed)

Created:
11 years, 6 months ago by Erik does not do reviews
Modified:
9 years, 7 months ago
Reviewers:
Matt Perry, rafaelw
CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, Ben Goodger (Google)
Visibility:
Public.

Description

Clean up a few startup and shutdown dependencies which should fix some of the extension browser_tests. Specifically, this includes: * make ExtensionsService own ExtensionProcessManager so that they have the same lifetime * git rid of notifications from unload all to avoid treating these notifications like real unload / uninstall events * fix teardown logic in ExtensionShelfModelTest * ExtensionView removes itself from the view hierarchy on destruction * ExtensionProcessManager waits for EXTENSIONS_READY to load background pages BUG=15080 TEST=browser_tests.exe --gtest_filter=ExtensionShelfModelTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19122

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -33 lines) Patch
M chrome/browser/extensions/extension_process_manager.cc View 2 chunks +17 lines, -6 lines 2 comments Download
M chrome/browser/extensions/extension_shelf_model_unittest.cc View 4 chunks +9 lines, -12 lines 1 comment Download
M chrome/browser/extensions/extensions_service.h View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 7 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/profile.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profile.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/views/extensions/extension_view.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik does not do reviews
11 years, 6 months ago (2009-06-23 22:49:21 UTC) #1
Matt Perry
LGTM http://codereview.chromium.org/147051/diff/1/3 File chrome/browser/extensions/extension_shelf_model_unittest.cc (right): http://codereview.chromium.org/147051/diff/1/3#newcode108 Line 108: // before the rest of InProcessBrowserTest. update ...
11 years, 6 months ago (2009-06-23 23:05:35 UTC) #2
rafaelw
http://codereview.chromium.org/147051/diff/1/6 File chrome/browser/extensions/extension_process_manager.cc (right): http://codereview.chromium.org/147051/diff/1/6#newcode36 Line 36: if (service && service->is_ready()) Can this test ever ...
11 years, 6 months ago (2009-06-24 23:04:21 UTC) #3
Erik does not do reviews
11 years, 6 months ago (2009-06-25 16:19:08 UTC) #4
http://codereview.chromium.org/147051/diff/1/6
File chrome/browser/extensions/extension_process_manager.cc (right):

http://codereview.chromium.org/147051/diff/1/6#newcode36
Line 36: if (service && service->is_ready())
On 2009/06/24 23:04:22, rafaelw wrote:
> Can this test ever return true?

Good point.  It can't any more.  I'll fix this in a follow-on.

Powered by Google App Engine
This is Rietveld 408576698