Issue 147035: Change RunPythonUnitTests() to run the unit tests in a separate process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147035: Change RunPythonUnitTests() to run the unit tests in a separate process. (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Jói Sigurðsson

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Change RunPythonUnitTests() to run the unit tests in a separate process. The unit tests could modify global state in hard-to-revert ways and would make the PRESUBMIT.py check flaky. Having the test running out of process alleviate any potential issue at the cost of speed (more noticeable on Windows). TEST=unit tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19248

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -106 lines)			Patch
M	presubmit_canned_checks.py	View	1 chunk	+42 lines, -24 lines	1 comment	Download
M	presubmit_support.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/presubmit_unittest.py	View	6 chunks	+46 lines, -82 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói Sigurðsson

11 years, 6 months ago (2009-06-23 20:03:50 UTC) #2

LGTM with comment correction

http://codereview.chromium.org/147035/diff/1/2
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/147035/diff/1/2#newcode301
Line 301: # Discard the output if returncode != 0
!=   ->   ==

Expand Messages | Collapse Messages