Add linux-gate.so to the minidump mappings list by checking for the load addr....

Add linux-gate.so to the minidump mappings list by checking for the load address in the aux vector and adding a filename of linux-gate.so when we encounter that load address.  This is necessary for crash reporting to walk the stack correctly when a crash happens while in a system call.

[agl, 2009-06-24 20:02:24]

I disagree with stars on the left personally, but it's the style so I don't see
why I should make other people suffer too :)

http://codereview.chromium.org/147032/diff/1018/1020
File breakpad/linux/linux_dumper.cc (right):

http://codereview.chromium.org/147032/diff/1018/1020#newcode147
Line 147: if (total_length > NAME_MAX) {
>=

http://codereview.chromium.org/147032/diff/1018/1020#newcode154
Line 154: memcpy(path + 6 + pid_len + 1, node, my_strlen(node));
This is the 3rd use of my_strlen(node). Might be worth caching it. No big deal.

http://codereview.chromium.org/147032/diff/1018/1020#newcode181
Line 181: return (void *)one_aux_entry.a_un.a_val;
stars on the left: "(void*)"

http://codereview.chromium.org/147032/diff/1018/1020#newcode198
Line 198: const void *linux_gate_loc;
stars on the left.

http://codereview.chromium.org/147032/diff/1018/1020#newcode230
Line 230: (void *)module->start_addr == linux_gate_loc) {
stars on the left

http://codereview.chromium.org/147032/diff/1018/1021
File breakpad/linux/linux_dumper.h (right):

http://codereview.chromium.org/147032/diff/1018/1021#newcode126
Line 126: void *FindBeginningOfLinuxGateSharedLibrary(const pid_t pid) const;
stars on the left.

[nealsid, 2009-06-25 01:07:37]

Updated, addressed all comments.

Thanks,
Neal

http://codereview.chromium.org/147032/diff/1018/1020
File breakpad/linux/linux_dumper.cc (right):

http://codereview.chromium.org/147032/diff/1018/1020#newcode147
Line 147: if (total_length > NAME_MAX) {
On 2009/06/24 20:02:24, agl wrote:
> >=

Done.

http://codereview.chromium.org/147032/diff/1018/1020#newcode154
Line 154: memcpy(path + 6 + pid_len + 1, node, my_strlen(node));
On 2009/06/24 20:02:24, agl wrote:
> This is the 3rd use of my_strlen(node). Might be worth caching it. No big
deal.

Done.

http://codereview.chromium.org/147032/diff/1018/1020#newcode181
Line 181: return (void *)one_aux_entry.a_un.a_val;
On 2009/06/24 20:02:24, agl wrote:
> stars on the left: "(void*)"

Done. Also changed to reinterpret_cast for lint error.

http://codereview.chromium.org/147032/diff/1018/1020#newcode198
Line 198: const void *linux_gate_loc;
On 2009/06/24 20:02:24, agl wrote:
> stars on the left.

Done.

http://codereview.chromium.org/147032/diff/1018/1020#newcode230
Line 230: (void *)module->start_addr == linux_gate_loc) {
On 2009/06/24 20:02:24, agl wrote:
> stars on the left

Done.

http://codereview.chromium.org/147032/diff/1018/1021
File breakpad/linux/linux_dumper.h (right):

http://codereview.chromium.org/147032/diff/1018/1021#newcode126
Line 126: void *FindBeginningOfLinuxGateSharedLibrary(const pid_t pid) const;
On 2009/06/24 20:02:24, agl wrote:
> stars on the left.

I hope I got all of them!
Done.

[agl, 2009-06-25 01:09:29]

LGTM