Issue 147022: Workaround a gcc 4.4 bug....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147022: Workaround a gcc 4.4 bug.... (Closed)

Created:
11 years, 6 months ago by Feng Qian

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Workaround a gcc 4.4 bug. Gcc generates wrong vtable entries for certain code pattern. The change in heap.cc has detailed explanation. Committed: http://code.google.com/p/v8/source/detail?r=2299

Patch Set 1 #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -16 lines)			Patch
	M	src/heap.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	src/heap.cc	View		1 chunk	+39 lines, -16 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM apart from the comments. http://codereview.chromium.org/147022/diff/1/2 File src/heap.cc (right): http://codereview.chromium.org/147022/diff/1/2#newcode1291 Line 1291: // gcc-4.4 has ...

11 years, 6 months ago (2009-06-24 07:38:31 UTC) #2

Feng Qian

11 years, 5 months ago (2009-06-29 20:54:24 UTC) #3

Rephrased comment and removed bug references.

On 2009/06/24 07:38:31, Erik Corry wrote:
> LGTM apart from the comments.
> 
> http://codereview.chromium.org/147022/diff/1/2
> File src/heap.cc (right):
> 
> http://codereview.chromium.org/147022/diff/1/2#newcode1291
> Line 1291: // gcc-4.4 has problem to generate the correct vtables if the
> following
> Should be "gcc-4.4 has problems generating..."
> 
> I don't understand the comment.  It doesn't seem like vtables are being
> generated here.
> 
> http://codereview.chromium.org/147022/diff/1/2#newcode1300
> Line 1300: // Possible gcc bug:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32327
> Is this relevant?  According to the bug this was fixed in gcc-4.3.

Expand Messages | Collapse Messages