Issue 147019: Ignore SIGPIPE when running tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147019: Ignore SIGPIPE when running tests (Closed)

Created:
11 years, 6 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
agl, jeremy

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Ignore SIGPIPE when running tests. BUG=15046 TEST=unit_tests --gtest_filter=IPCSyncChannelTest.NoHang should complete and not be taken down by SIGPIPE; when EPIPE occurs, a harmless "broken pipe" message should be logged. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19045

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -1 line)			Patch
	M	base/test_suite.h	View	1	2 chunks	+18 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jeremy

LGTM, thanks for doing this! http://codereview.chromium.org/147019/diff/1/2 File base/test_suite.h (right): http://codereview.chromium.org/147019/diff/1/2#newcode117 Line 117: #if defined(OS_POSIX) Could ...

11 years, 6 months ago (2009-06-23 17:22:41 UTC) #2

Sure, I've added a comment.

Expand Messages | Collapse Messages