Allow extension extensions to be case-insensitive.

chrome/browser/download/download_manager.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_manager.h"
 
 #include "app/l10n_util.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
 #include "base/rand_util.h"
 #include "base/stl_util-inl.h"
 #include "base/string_util.h"
 #include "base/sys_string_conversions.h"
 #include "base/task.h"
 #include "base/thread.h"
 #include "base/timer.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_file.h"
 #include "chrome/browser/extensions/extensions_service.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/renderer_host/render_process_host.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
 #include "chrome/browser/renderer_host/resource_dispatcher_host.h"
 #include "chrome/browser/tab_contents/tab_util.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
-#include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/platform_util.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/pref_service.h"
 #include "googleurl/src/gurl.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "net/base/mime_util.h"
 #include "net/base/net_util.h"
@@ skipping 779 matching lines @@
             this, &DownloadManager::ProceedWithFinishedDangerousDownload,
             download->db_handle(),
             download->full_path(), download->original_name()));
     return;
   }
   ContinueDownloadFinished(download);
 }
 
 void DownloadManager::DownloadRenamedToFinalName(int download_id,
                                                  const FilePath& full_path) {
-  FilePath::StringType extension = full_path.Extension();
-  // Drop the leading period.
-  if (extension.size() > 0)
-    extension = extension.substr(1);
-
-  if (extension == chrome::kExtensionFileExtension) {
+  if (Extension::IsExtension(full_path))
     OpenChromeExtension(full_path);
-  }
 }
 
 void DownloadManager::ContinueDownloadFinished(DownloadItem* download) {
   // If this was a dangerous download, it has now been approved and must be
   // removed from dangerous_finished_ so it does not get deleted on shutdown.
   DownloadMap::iterator it = dangerous_finished_.find(download->id());
   if (it != dangerous_finished_.end())
     dangerous_finished_.erase(it);
 
   // Notify our observers that we are complete (the call to Finished() set the
   // state to complete but did not notify).
   download->UpdateObservers();
 
   // Open the download if the user or user prefs indicate it should be.
   FilePath::StringType extension = download->full_path().Extension();
-  // Drop the leading period.
-  if (extension.size() > 0)
-    extension = extension.substr(1);
 
   // Handle chrome extensions explicitly and skip the shell execute.
-  if (extension == chrome::kExtensionFileExtension) {
+  if (Extension::IsExtension(download->full_path())) {
     // Skip the shell execute. This will be handled in
     // DownloadRenamedToFinalName
     return;
   }
 
   if (download->open_when_complete() || ShouldOpenFileExtension(extension))
     OpenDownloadInShell(download, NULL);
 }
 
 // Called on the file thread.  Renames the downloaded file to its original name.
@@ skipping 343 matching lines @@
 void DownloadManager::ShowDownloadInShell(const DownloadItem* download) {
   DCHECK(file_manager_);
   file_loop_->PostTask(FROM_HERE,
       NewRunnableMethod(file_manager_,
                         &DownloadFileManager::OnShowDownloadInShell,
                         FilePath(download->full_path())));
 }
 
 void DownloadManager::OpenDownload(const DownloadItem* download,
                                    gfx::NativeView parent_window) {
-  FilePath::StringType extension = download->full_path().Extension();
-  // Drop the leading period.
-  if (extension.size() > 0)
-    extension = extension.substr(1);
-
   // Open Chrome extensions with ExtensionsService. For everything else do shell
   // execute.
-  if (extension == chrome::kExtensionFileExtension) {
+  if (Extension::IsExtension(download->full_path())) {
     OpenChromeExtension(download->full_path());
   } else {
     OpenDownloadInShell(download, parent_window);
   }
 }
 
 void DownloadManager::OpenChromeExtension(const FilePath& full_path) {
   profile_->GetOriginalProfile()->GetExtensionsService()->
       InstallExtension(full_path);
 }
@@ skipping 14 matching lines @@
   else
     auto_open_.erase(extension);
   SaveAutoOpens();
 }
 
 bool DownloadManager::ShouldOpenFileExtension(
     const FilePath::StringType& extension) {
   // Special-case Chrome extensions as always-open.
   if (!IsExecutable(extension) &&
       (auto_open_.find(extension) != auto_open_.end() ||
-       extension == chrome::kExtensionFileExtension))
+       Extension::IsExtension(FilePath(extension))))
     return true;
   return false;
 }
 
 static const char* kExecutableWhiteList[] = {
   // JavaScript is just as powerful as EXE.
   "text/javascript",
   "text/javascript;version=*",
   // Registry files can cause critical changes to the MS OS behavior.
   // Addition of this mimetype also addresses bug 7337.
@@ skipping 203 matching lines @@
   }
 
   requestor->SetDownloads(searched_downloads);
 }
 
 void DownloadManager::ShowDownloadInBrowser(const DownloadCreateInfo& info,
                                             DownloadItem* download) {
   // Extension downloading skips the shelf.  This is a temporary fix until
   // we can modularize the download system and develop specific extensiona
   // install UI.
-  FilePath::StringType extension = info.path.Extension();
-  // Ignore the leading period.
-  if (extension.find(chrome::kExtensionFileExtension) == 1)
+  if (Extension::IsExtension(info.path))
     return;
 
   // The 'contents' may no longer exist if the user closed the tab before we get
   // this start completion event. If it does, tell the origin TabContents to
   // display its download shelf.
   TabContents* contents =
       tab_util::GetTabContentsByID(info.render_process_id, info.render_view_id);
 
   // If the contents no longer exists, we start the download in the last active
   // browser. This is not ideal but better than fully hiding the download from
   // the user.
   if (!contents) {
     Browser* last_active = BrowserList::GetLastActive();
     if (last_active)
       contents = last_active->GetSelectedTabContents();
   }
 
   if (contents)
     contents->OnStartDownload(download);
 }
 
 // Clears the last download path, used to initialize "save as" dialogs.
 void DownloadManager::ClearLastDownloadPath() {
   last_download_path_ = FilePath();
 }