Issue 147015: Disable TR1 for windows (set _HAS_TR1=0). This change requires a clobber build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147015: Disable TR1 for windows (set _HAS_TR1=0). This change requires a clobber build. (Closed)

Created:
11 years, 6 months ago by awong

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, M-A Ruel

CC:
chromium-reviews_googlegroups.com, John Grabowski

Visibility:
Public.

Description

Disable TR1 for windows (set _HAS_TR1=0). This change requires a clobber build.

Patch Set 2 : Enable layout test. #

Patch Set 3 : Undo last upload. #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	build/internal/essential.vsprops	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

http://codereview.chromium.org/147015/diff/1/2 File build/common.gypi (right): http://codereview.chromium.org/147015/diff/1/2#newcode451 Line 451: '_HAS_TR1=0', can't you just remove the line? http://codereview.chromium.org/147015/diff/1/3 ...

11 years, 6 months ago (2009-06-23 16:26:35 UTC) #2

lgtm as-is.

_HAS_TR1=0 is required.