Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2015)

Unified Diff: chrome/browser/tab_contents/tab_contents_view_gtk.cc

Issue 147011: Integrating GtkIMContext into the RenderWidgetHostViewGtk class (Take 2).... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/tab_contents_view_gtk.cc
===================================================================
--- chrome/browser/tab_contents/tab_contents_view_gtk.cc (revision 19224)
+++ chrome/browser/tab_contents/tab_contents_view_gtk.cc (working copy)
@@ -308,6 +308,14 @@
return;
}
+ // Filter out pseudo key events created by GtkIMContext signal handlers.
+ // Since GtkIMContext signal handlers don't use GdkEventKey objects, its
+ // |event.os_event| values are dummy values (or NULL.)
+ // We should filter out these pseudo key events to prevent unexpected
+ // behaviors caused by them.
+ if (event.type == WebKit::WebInputEvent::Char)
+ return;
+
BrowserWindowGtk* browser_window =
BrowserWindowGtk::GetBrowserWindowForNativeWindow(window);
DCHECK(browser_window);
« no previous file with comments | « chrome/browser/renderer_host/render_widget_host_view_gtk.cc ('k') | chrome/common/native_web_keyboard_event.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698