Issue 1462001: Use internal pdf plugin with --internal-pdf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1462001: Use internal pdf plugin with --internal-pdf (Closed)

Created:
10 years, 9 months ago by jam

Modified:
9 years, 6 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use internal pdf plugin with --internal-pdf Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42886

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -0 lines)			Patch
M	chrome/browser/plugin_service.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_paths.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_paths.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_process_impl.cc	View	1	2 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

(removed chromium-reviews) I'd like to check this in so that others can try out the ...

10 years, 9 months ago (2010-03-26 20:20:01 UTC) #1

cpu_(ooo_6.6-7.5)

10 years, 9 months ago (2010-03-26 21:14:14 UTC) #2

lgtm

The one nit, that you should fix at some point is to have it named like
xxx32.dll so if we go to 64 bits we keep uniform names.

btw, what we agreed for the 'other' one was gcxxx32.dll but I don't care that
much.

On 2010/03/26 20:20:01, John Abd-El-Malek wrote:
> (removed chromium-reviews)
> 
> I'd like to check this in so that others can try out the pdf plugin and the
devs
> working on it don't have to keep patching this in each checkout.

Expand Messages | Collapse Messages