Paint the spy guy.

Paint the spy guy.

BUG=none
TEST=go incognito, toggle custom frame drawing


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19220

[tony, 2009-06-25 00:18:40]

http://codereview.chromium.org/146122/diff/1/5
File chrome/browser/gtk/browser_titlebar.cc (right):

http://codereview.chromium.org/146122/diff/1/5#newcode86
Line 86: GtkWidget* spy_guy = gtk_fixed_new();
Did you consider just using a GtkImage?  It has padding methods from GtkMisc so
you can position it (or maybe you can put it in a gtk alignment).

[Evan Stade, 2009-06-25 00:28:17]

http://codereview.chromium.org/146122/diff/1/5
File chrome/browser/gtk/browser_titlebar.cc (right):

http://codereview.chromium.org/146122/diff/1/5#newcode86
Line 86: GtkWidget* spy_guy = gtk_fixed_new();
On 2009/06/25 00:18:40, tony wrote:
> Did you consider just using a GtkImage?  It has padding methods from GtkMisc
so
> you can position it (or maybe you can put it in a gtk alignment).

do GtkImages flip for RTL? (From looking at their source, I think they don't,
only the alignment of the image changes.)

[tony, 2009-06-25 01:21:28]

You are correct, GtkImage doesn't do RTL.  Sadness.  It seems like we will want
to do this more in the future so we should perhaps make a gtk widget that does
the right thing.

Anyway, for now this LGTM.