Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 146121: Fix a couple of integer issues in Pickle deserialization (Closed)

Created:
11 years, 6 months ago by Chris Evans
Modified:
9 years, 6 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix a couple of integer issues in Pickle deserialization. Neither represent a significant risk because the code is not directly exposed to user input. In addition, neither error leads to memory corruption. At worse, there's a C++ exception or abort(). BUG=NONE TEST=PickleTest.EvilLengths Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19249

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M base/pickle.cc View 2 chunks +4 lines, -1 line 0 comments Download
M base/pickle_unittest.cc View 1 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Chris Evans
11 years, 6 months ago (2009-06-25 00:00:38 UTC) #1
cpu_(ooo_6.6-7.5)
11 years, 6 months ago (2009-06-25 00:33:24 UTC) #2
LGTM, one comment:

http://codereview.chromium.org/146121/diff/1/3
File base/pickle_unittest.cc (right):

http://codereview.chromium.org/146121/diff/1/3#newcode226
Line 226: for (int i = 0; i < 100000; ++i)
use std::string str(10000, 'A');

Powered by Google App Engine
This is Rietveld 408576698