Issue 146081: X64: Implemented LikelySmiBinaryOperation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146081: X64: Implemented LikelySmiBinaryOperation (Closed)

Created:
11 years, 6 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

X64: Implemented LikelySmiBinaryOperation

Patch Set 1 #

Total comments: 4

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+442 lines, -17 lines)			Patch
	M	src/x64/codegen-x64.cc	View		8 chunks	+442 lines, -17 lines	4 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 6 months ago (2009-06-24 11:39:35 UTC) #2

LGTM, with comments.

http://codereview.chromium.org/146081/diff/1/2
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/146081/diff/1/2#newcode40
Line 40: #include "macro-assembler.h"
Surely this was already included through a dependency, otherwise nothing would
have been working.

If this is the right master dependency, then remove others, otherwise, remove
this.

http://codereview.chromium.org/146081/diff/1/2#newcode1410
Line 1410: frame_->Push(kScratchRegister);
This must be reversed again - we cannot push kScratchRegister on the virtual
frame.

http://codereview.chromium.org/146081/diff/1/2#newcode2920
Line 2920: __ addq(answer.reg(), right->reg());  // Add optimistically.
I think we want addl here.

http://codereview.chromium.org/146081/diff/1/2#newcode2925
Line 2925: __ subq(answer.reg(), right->reg());  // Subtract optimistically.
subl

Expand Messages | Collapse Messages