Issue 146076: Changed benchmark html and css files to be validating HTML 4.01 and CSS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146076: Changed benchmark html and css files to be validating HTML 4.01 and CSS. (Closed)

Created:
11 years, 6 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Visibility:
Public.

Description

Changed benchmark html and css files to be almost validating HTML 4.01 and CSS.

Patch Set 1 #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -36 lines)			Patch
	M	benchmarks/run.html	View		6 chunks	+21 lines, -16 lines	2 comments	Download
	M	benchmarks/style.css	View		4 chunks	+18 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

http://codereview.chromium.org/146076/diff/1/2 File benchmarks/run.html (right): http://codereview.chromium.org/146076/diff/1/2#newcode17 Line 17: <link type="text/css" rel="stylesheet" href="style.css"> Support for writing link ...

11 years, 6 months ago (2009-06-24 07:58:15 UTC) #2

Christian Plesner Hansen

11 years, 6 months ago (2009-06-24 10:06:35 UTC) #4

Let's try that again, this time with comments.

LGTM.

http://codereview.chromium.org/146076/diff/1/2
File benchmarks/run.html (right):

http://codereview.chromium.org/146076/diff/1/2#newcode17
Line 17: <link type="text/css" rel="stylesheet" href="style.css">
As discussed, I would suggest not making this change.

Expand Messages | Collapse Messages