Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 146057: Making browser test work (again) on Linux (Closed)

Created:
11 years, 6 months ago by jcampan
Modified:
9 years, 7 months ago
Reviewers:
agl, sky
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

On Linux, the path to the exe is used to fork renderer processes. This was causing the browser tests to create browser tests instead of a renderer processes. Also the SSL tests now pass on Linux and have been enabled. BUG=None TEST=Run the browser tests on Linux. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19257

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Total comments: 4

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -24 lines) Patch
M base/path_service.h View 1 chunk +3 lines, -0 lines 0 comments Download
M base/path_service.cc View 1 2 3 4 5 6 2 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 2 chunks +0 lines, -15 lines 0 comments Download
M chrome/test/in_process_browser_test.cc View 1 2 3 4 5 6 7 1 chunk +18 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jcampan
11 years, 6 months ago (2009-06-23 23:28:23 UTC) #1
agl
http://codereview.chromium.org/146057/diff/27/1025 File chrome/test/in_process_browser_test.cc (right): http://codereview.chromium.org/146057/diff/27/1025#newcode37 Line 37: const wchar_t* const kChromeExeName = L"chrome"; .exe on ...
11 years, 6 months ago (2009-06-24 02:01:55 UTC) #2
sky
http://codereview.chromium.org/146057/diff/27/1024 File base/path_service.cc (right): http://codereview.chromium.org/146057/diff/27/1024#newcode224 Line 224: if (!file_util::PathExists(file_path) && should this be an || ...
11 years, 6 months ago (2009-06-24 15:23:46 UTC) #3
jcampan
http://codereview.chromium.org/146057/diff/27/1024 File base/path_service.cc (right): http://codereview.chromium.org/146057/diff/27/1024#newcode224 Line 224: if (!file_util::PathExists(file_path) && On 2009/06/24 15:23:46, sky wrote: ...
11 years, 6 months ago (2009-06-24 16:35:34 UTC) #4
sky
11 years, 6 months ago (2009-06-24 17:04:49 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698