Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 146036: Add support for vertical split into SingleSplitView. (Closed)

Created:
11 years, 6 months ago by pfeldman
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add support for vertical split into SingleSplitView. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19107

Patch Set 1 #

Total comments: 9

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -43 lines) Patch
M chrome/browser/views/bookmark_manager_view.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M views/controls/single_split_view.h View 1 3 chunks +30 lines, -9 lines 0 comments Download
M views/controls/single_split_view.cc View 1 5 chunks +61 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pfeldman
11 years, 6 months ago (2009-06-23 17:17:56 UTC) #1
Ben Goodger (Google)
sky should review.
11 years, 6 months ago (2009-06-23 18:04:44 UTC) #2
sky
http://codereview.chromium.org/146036/diff/1/4 File views/controls/single_split_view.cc (right): http://codereview.chromium.org/146036/diff/1/4#newcode67 Line 67: height = std::max(height, pref.height()); for vertical split the ...
11 years, 6 months ago (2009-06-23 18:28:02 UTC) #3
pfeldman
Thanks for the review. http://codereview.chromium.org/146036/diff/1/4 File views/controls/single_split_view.cc (right): http://codereview.chromium.org/146036/diff/1/4#newcode67 Line 67: height = std::max(height, pref.height()); ...
11 years, 6 months ago (2009-06-23 18:46:11 UTC) #4
sky
11 years, 6 months ago (2009-06-23 19:33:19 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698