Issue 1460001: Don't strip main from the browser or helper app executables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1460001: Don't strip main from the browser or helper app executables (Closed)

Created:
10 years, 9 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Don't strip main from the browser or helper app executables. This helps backtraces of stripped executables look more reasonable. BUG=39232 TEST=gdb backtrace in a stripped executable with no symbols loaded should show thread 0 beginning in main Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42817

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -6 lines)			Patch
MM	build/mac/strip_from_xcode	View	1 2	3 chunks	+25 lines, -5 lines	0 comments	Download
A	chrome/app/app.saves	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/app/chrome_exe_main.mm	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_dll.gypi	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_exe.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages