Issue 1456001: Small improvements with code patching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1456001: Small improvements with code patching (Closed)

Created:
10 years, 9 months ago by Peter Rybin

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Small improvements with code patching Committed: http://code.google.com/p/v8/source/detail?r=4358

Patch Set 2 : more improvements #

Patch Set 4 : follow codereview #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -12 lines)			Patch
	M	src/liveedit.cc	View	1 2 3	3 chunks	+37 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM when it lints. http://codereview.chromium.org/1456001/diff/4001/5001 File src/liveedit.cc (right): http://codereview.chromium.org/1456001/diff/4001/5001#newcode450 src/liveedit.cc:450: static bool IsStubCode(Code* code) { ...

10 years, 8 months ago (2010-04-07 07:06:05 UTC) #2

Peter Rybin

10 years, 8 months ago (2010-04-07 17:42:54 UTC) #3

http://codereview.chromium.org/1456001/diff/4001/5001
File src/liveedit.cc (right):

http://codereview.chromium.org/1456001/diff/4001/5001#newcode450
src/liveedit.cc:450: static bool IsStubCode(Code* code) {
On 2010/04/07 07:06:05, Søren Gjesse wrote:
> I will suggest making a IsJSFunctionCode which checks == with Code::FUNCTION
> instead. The term "stub" is a bit overloaded.

Done.

http://codereview.chromium.org/1456001/diff/4001/5001#newcode465
src/liveedit.cc:465: if (!IsStubCode(shared_info->code())) {
On 2010/04/07 07:06:05, Søren Gjesse wrote:
> Maybe (shared->code()->kind() == Code::FUNCTION) is just as good here?

I am not sure I won't need more checks later. I also use this function in other
place, so I'd rather not inline it.

http://codereview.chromium.org/1456001/diff/4001/5001#newcode472
src/liveedit.cc:472: Handle<Code> new_original_code =
Factory::CopyCode(compile_info_wrapper.GetFunctionCode());
On 2010/04/07 07:06:05, Søren Gjesse wrote:
> Long line, please make sure it lints.

Sorry about this.
Done