Issue 14500: Temp experiment to confirm theory in crbug.com/5555....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14500: Temp experiment to confirm theory in crbug.com/5555.... (Closed)

Created:
12 years ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Temp experiment to confirm theory in crbug.com/5555. The idea is that by using a comparator which has an (initialized) data member, pop() will avoid a sideffect that reads uninitialized data. Will revert this once it has run on bot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7125

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -9 lines)			Patch
M	base/message_loop.h	View	1 chunk	+12 lines, -1 line	0 comments	Download
M	net/proxy/proxy_script_fetcher.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/proxy/proxy_script_fetcher_unittest.cc	View	6 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages