net/url_request/url_request_unittest.h - Issue 14497: POSIX: don't leak FDs when launching child Processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_unittest.h

Issue 14497: POSIX: don't leak FDs when launching child Processes. (Closed)

Patch Set: Fix Windows Compilation Created 12 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_unittest.h

diff --git a/net/url_request/url_request_unittest.h b/net/url_request/url_request_unittest.h

index e2b8ca3368c35b05c92ab106bb12587438e8a91d..52fa429cea8d3e9922f1c1b8c2ce4d7e5ce58642 100644

--- a/net/url_request/url_request_unittest.h

+++ b/net/url_request/url_request_unittest.h

@@ -342,8 +342,9 @@ class TestServer : public base::ProcessFilter {

if (!cert_path.empty())

command_line.push_back("--https=" + WideToUTF8(cert_path));

+ base::file_handle_mapping_vector no_mappings;

ASSERT_TRUE(

- base::LaunchApp(command_line, false, &process_handle_)) <<

+ base::LaunchApp(command_line, no_mappings, false, &process_handle_)) <<

"Failed to launch " << command_line[0] << " ...";

#endif

« no previous file with comments | « base/process_util_unittest.cc ('k') | no next file » | no next file with comments »