POSIX: don't leak FDs when launching child Processes.

base/multiprocess_test.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_MULTIPROCESS_TEST_H__
 #define BASE_MULTIPROCESS_TEST_H__
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/process_util.h"
@@ skipping 48 matching lines @@
   // Returns the handle to the child, or NULL on failure
   //
   // TODO(darin): re-enable this once we have base/debug_util.h
   // ProcessDebugFlags(&cl, DebugUtil::UNKNOWN, false);
   base::ProcessHandle SpawnChild(const std::wstring& procname) {
     return SpawnChild(procname, false);
   }
 
   base::ProcessHandle SpawnChild(const std::wstring& procname,
                                  bool debug_on_start) {
+#if defined(OS_WIN)
+    return SpawnChildImpl(procname, false);
+#elif defined(OS_POSIX)
+    base::file_handle_mapping_vector empty_file_list;
+    return SpawnChildImpl(procname, empty_file_list, false);
+#endif
+  }
+
+#if defined(OS_POSIX)
+  base::ProcessHandle SpawnChild(
+      const std::wstring& procname,
+      const base::file_handle_mapping_vector& fds_to_map,
+      bool debug_on_start) {
+    return SpawnChildImpl(procname, fds_to_map, false);
+  }
+
+#endif
+
+ private:
+#if defined(OS_WIN)
+  base::ProcessHandle SpawnChildImpl(
+      const std::wstring& procname,
+      bool debug_on_start) {
     CommandLine cl;
     base::ProcessHandle handle = static_cast<base::ProcessHandle>(NULL);
-
-#if defined(OS_WIN)
     std::wstring clstr = cl.command_line_string();
     CommandLine::AppendSwitchWithValue(&clstr, kRunClientProcess, procname);
 
     if (debug_on_start) {
       CommandLine::AppendSwitch(&clstr, switches::kDebugOnStart);
     }
 
     base::LaunchApp(clstr, false, true, &handle);
+    return handle;
+  }
 #elif defined(OS_POSIX)
+  base::ProcessHandle SpawnChildImpl(
+      const std::wstring& procname,
+      const base::file_handle_mapping_vector& fds_to_map,
+      bool debug_on_start) {
+    CommandLine cl;
+    base::ProcessHandle handle = static_cast<base::ProcessHandle>(NULL);
+
     std::vector<std::string> clvec(cl.argv());
     std::wstring wswitchstr =
         CommandLine::PrefixedSwitchStringWithValue(kRunClientProcess,
                                                    procname);
     if (debug_on_start) {
       CommandLine::AppendSwitch(&wswitchstr, switches::kDebugOnStart);
     }
 
     std::string switchstr = WideToUTF8(wswitchstr);
     clvec.push_back(switchstr.c_str());
-    base::LaunchApp(clvec, false, &handle);
-#endif
-
+    base::LaunchApp(clvec, fds_to_map, false, &handle);
     return handle;
   }
+#endif
 };
 
 #endif  // BASE_MULTIPROCESS_TEST_H__