Underlying functionality for generating native Visual Studio solution files:...

Underlying functionality for generating native Visual Studio solution files:
* New _Node_MSVS.py module (from rspangler) with new MSVSFolder(),
  MSVSProject() and MSVSSolution() Nodes.  This will eventually
  become a new SCons/Node/MSVS.py module in upstream SCons.
* New MSVSNew.py Tool module imports MSVS.py (either from SCons.Node
  or from our temporary _Node_MSVS.py module) and attaches the
  appropriate environment methods.
* MSVSSolution().Write() will generate a solution file based on
  explicit configuration in the SConscript files.
* While we're here, define $SQLITE_DIR, which will be used by
  the next checkins.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7120

[bradn, 2008-12-16 19:19:08]

http://codereview.chromium.org/14467/diff/1/4
File site_scons/site_tools/MSVSNew.py (right):

http://codereview.chromium.org/14467/diff/1/4#newcode28
Line 28: Tool-specific initialization for generic Posix C compilers.
Huh? This seems off.

http://codereview.chromium.org/14467/diff/1/3
File site_scons/site_tools/_Node_MSVS.py (right):

http://codereview.chromium.org/14467/diff/1/3#newcode36
Line 36: #!/usr/bin/python2.4
Uh this seems to be in the wrong place.

http://codereview.chromium.org/14467/diff/1/3#newcode156
Line 156: def initialize(self, path, name = None, entries = None, guid = None,
items = None):
Long line.

[sgk, 2008-12-16 19:39:57]

http://codereview.chromium.org/14467/diff/1/4
File site_scons/site_tools/MSVSNew.py (right):

http://codereview.chromium.org/14467/diff/1/4#newcode28
Line 28: Tool-specific initialization for generic Posix C compilers.
On 2008/12/16 19:19:08, bradn wrote:
> Huh? This seems off.

Done.

http://codereview.chromium.org/14467/diff/1/3
File site_scons/site_tools/_Node_MSVS.py (right):

http://codereview.chromium.org/14467/diff/1/3#newcode36
Line 36: #!/usr/bin/python2.4
On 2008/12/16 19:19:08, bradn wrote:
> Uh this seems to be in the wrong place.

Done.

http://codereview.chromium.org/14467/diff/1/3#newcode156
Line 156: def initialize(self, path, name = None, entries = None, guid = None,
items = None):
On 2008/12/16 19:19:08, bradn wrote:
> Long line.

Done.

[bradn, 2008-12-16 19:43:13]

LGTM

[Nicolas Sylvain, 2008-12-17 00:49:27]

lg, can't wait to see it in action :)

http://codereview.chromium.org/14467/diff/210/10
File site_scons/site_tools/_Node_MSVS.py (right):

http://codereview.chromium.org/14467/diff/210/10#newcode331
Line 331: if self.websiteProperties:
Please don't add this stuff. It burns my eyes to see that people added this to
our vcproj, we should not generate the vcproj with the same error :)