Platform cleanup in browser/ and porting of few files.

Platform cleanup in browser/ and porting of few files.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7142

[Evan Stade, 2008-12-16 18:47:48]

I don't know if you have seen this cl, but in case you haven't:

http://codereview.chromium.org/14408/show

[Mark Mentovai, 2008-12-16 19:39:10]

lg

http://codereview.chromium.org/14466/diff/1/6
File chrome/browser/url_fetcher.cc (right):

http://codereview.chromium.org/14466/diff/1/6#newcode18
Line 18: : ALLOW_THIS_IN_INITIALIZER_LIST(
Two more spaces at the beginning of this line, please.

http://codereview.chromium.org/14466/diff/1/2
File chrome/browser/url_fixer_upper_unittest.cc (right):

http://codereview.chromium.org/14466/diff/1/2#newcode326
Line 326: EXPECT_TRUE(file_util::Delete(new_dir, true));
Is full_path inside new_dir?  If so, can't we just delete new_dir recursively?

[Paweł Hajdan Jr., 2008-12-16 19:55:10]

http://codereview.chromium.org/14466/diff/1/6
File chrome/browser/url_fetcher.cc (right):

http://codereview.chromium.org/14466/diff/1/6#newcode18
Line 18: : ALLOW_THIS_IN_INITIALIZER_LIST(
On 2008/12/16 19:39:10, Mark Mentovai wrote:
> Two more spaces at the beginning of this line, please.

Done.

http://codereview.chromium.org/14466/diff/1/2
File chrome/browser/url_fixer_upper_unittest.cc (right):

http://codereview.chromium.org/14466/diff/1/2#newcode326
Line 326: EXPECT_TRUE(file_util::Delete(new_dir, true));
On 2008/12/16 19:39:10, Mark Mentovai wrote:
> Is full_path inside new_dir?  If so, can't we just delete new_dir recursively?

Done.

[Mark Mentovai, 2008-12-16 20:01:05]

OK, LGTM

[Mark Mentovai, 2008-12-17 20:04:23]

lgtm still

[Paweł Hajdan Jr., 2008-12-17 20:14:35]

On 2008/12/17 20:04:23, Mark Mentovai wrote:
> lgtm still

Thanks. I had to remove url_fixer changes because they broke on Windows
(url_fixer_upper_unittest does not link on Linux yet). The rest is committed.