Issue 14458: Removed the use of the ConsoleMessage::operator== as it has been responsible ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14458: Removed the use of the ConsoleMessage::operator== as it has been responsible ... (Closed)

Created:
12 years ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, Mads Ager (chromium)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Removed the use of the ConsoleMessage::operator== as it has been responsible for crashes while running the pagecycler tests. Console messages which are the same will now appear as separate messages in the inspector instead of apearing as a single message with a count indicator. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7077

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	webkit/port/page/inspector/InspectorController.cpp	View		1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

12 years ago (2008-12-17 07:35:40 UTC) #3

OK, let's see what this does to the pagecycler tests.  We should get this
functionality back in some form though.

Expand Messages | Collapse Messages