Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 14452: fixes issue 4376: Press "Tab" key to navigate - Text focus is showing... (Closed)

Created:
12 years ago by xji
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

This CL fixes issue 4376: Press "Tab" key to navigate - Text focus is showing at wrong place in Hebrew and Arabic. when drawing focus rectangle for CheckBox,the left point of the rectangle should be mirrored for RTL text. http://crbug.com/4376 TEST: 1. Launch RTL Chome (for ex: set language as Hebrew). 2. Go to > Customize and Control Google Chrome > Options > Under the Hood or any other Tab 3. Press tab key to navigate thought text options 4. The focus is properly set on the text. (without this fix, the focus is not properly set on the text). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/views/checkbox.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
xji
12 years ago (2008-12-16 01:47:19 UTC) #1
idana
LGTM
12 years ago (2008-12-16 02:46:13 UTC) #2
jungshik at Google
12 years ago (2008-12-16 18:21:58 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698