Issue 14451: Rebaseline delete-by-word-00[12] since the upstream expectation changed....

Issue 14451: Rebaseline delete-by-word-00[12] since the upstream expectation changed.... (Closed)

Created:
12 years ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Rebaseline delete-by-word-00[12] since the upstream expectation changed. (The mac version of this file was modified in webkit r38631.)

Patch Set 1 #

Patch Set 2 : Adding Linux cases #

Patch Set 3 : Delete the expected linux txts, as they're the same as windows. #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
M	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/deleting/delete-by-word-001-expected.checksum	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/deleting/delete-by-word-001-expected.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/deleting/delete-by-word-002-expected.checksum	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/deleting/delete-by-word-002-expected.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/deleting/delete-by-word-001-expected.checksum	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/deleting/delete-by-word-001-expected.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/deleting/delete-by-word-001-expected.txt	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/deleting/delete-by-word-002-expected.checksum	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/deleting/delete-by-word-002-expected.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/deleting/delete-by-word-002-expected.txt	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	webkit/tools/layout_tests/test_lists/tests_fixable.txt	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

Why are the windows and linux expected.txt files different? We should be matching font metrics.

12 years ago (2008-12-16 17:47:08 UTC) #2

Elliot Glaysher

There were no differences between those files; making a -linux version was just an error ...

12 years ago (2008-12-16 17:57:21 UTC) #3

tony

12 years ago (2008-12-16 18:01:00 UTC) #4

Great!  LGTM.

On 2008/12/16 17:57:21, Elliot Glaysher wrote:
> There were no differences between those files; making a -linux version was
just
> an error on my part. Deleted in patch set 3.

Expand Messages | Collapse Messages