Issue 14450: Some cleanup, using gfx::Size instead of CSize for ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14450: Some cleanup, using gfx::Size instead of CSize for ... (Closed)

Created:
12 years ago by Mohamed Mansour (USE mhm)

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Some cleanup, using gfx::Size instead of CSize for GridLayout code. BUG=2186 (http://crbug.com/2186)

Patch Set 2 : '' #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -14 lines)			Patch
	M	chrome/views/grid_layout.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/views/grid_layout.cc	View	1	4 chunks	+13 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/14450/diff/1/2 File chrome/views/grid_layout.cc (right): http://codereview.chromium.org/14450/diff/1/2#newcode810 Line 810: pref->set_height(0); Could you change these two methods to ...

12 years ago (2008-12-16 16:31:09 UTC) #3

Mohamed Mansour (USE mhm)

12 years ago (2008-12-16 17:23:24 UTC) #4

how do we close this review ?

Expand Messages | Collapse Messages

Issue 14450: Some cleanup, using gfx::Size instead of CSize for ... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages