Issue 14449: Makes the interactive bookmark bar view tests faster by disabling...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14449: Makes the interactive bookmark bar view tests faster by disabling... (Closed)

Created:
12 years ago by sky

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Makes the interactive bookmark bar view tests faster by disabling saving. This is why BookmarkBarViewTest9 keeps timing out. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7062

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	chrome/browser/bookmarks/bookmark_model.h	View	1	1 chunk	+6 lines, -0 lines	1 comment	Download
	M	chrome/browser/views/bookmark_bar_view_test.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jcampan

12 years ago (2008-12-16 17:24:12 UTC) #2

LGTM

http://codereview.chromium.org/14449/diff/9/204
File chrome/browser/bookmarks/bookmark_model.h (right):

http://codereview.chromium.org/14449/diff/9/204#newcode287
Line 287: 
Remove extra blank line

Expand Messages | Collapse Messages