Issue 14444: Comments and white space changes requested by Wan-Teh.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14444: Comments and white space changes requested by Wan-Teh. (Closed)

Created:
12 years ago by abarth-chromium

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Comments and white space changes requested by Wan-Teh. TBR=wtc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7018

Patch Set 1 #

Total comments: 3

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	base/base_switches.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	net/url_request/url_request_http_job.cc	View		1 chunk	+1 line, -1 line	3 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

http://codereview.chromium.org/14444/diff/1/2 File net/url_request/url_request_http_job.cc (right): http://codereview.chromium.org/14444/diff/1/2#newcode45 Line 45: CommandLine().HasSwitch(switches::kForceHTTPS); It's this line that is over-indented. Did ...

12 years ago (2008-12-16 00:16:31 UTC) #2

abarth-chromium

12 years ago (2008-12-16 00:18:26 UTC) #3

http://codereview.chromium.org/14444/diff/1/2
File net/url_request/url_request_http_job.cc (right):

http://codereview.chromium.org/14444/diff/1/2#newcode45
Line 45: CommandLine().HasSwitch(switches::kForceHTTPS);
I fail at reading code review comments.  Sorry about that.

Expand Messages | Collapse Messages