Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/browser/dom_ui/bookmarks_ui_uitest.cc

Issue 1429003: Marking the BookmarksUITest.ShouldRedirectToExtension test as flaky as this h... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/ui/ui_test.h" 5 #include "chrome/test/ui/ui_test.h"
6 6
7 #include "chrome/app/chrome_dll_resource.h" 7 #include "chrome/app/chrome_dll_resource.h"
8 #include "chrome/common/url_constants.h" 8 #include "chrome/common/url_constants.h"
9 #include "chrome/test/automation/browser_proxy.h" 9 #include "chrome/test/automation/browser_proxy.h"
10 #include "chrome/test/automation/tab_proxy.h" 10 #include "chrome/test/automation/tab_proxy.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 std::wstring out; 50 std::wstring out;
51 ASSERT_TRUE(tab->ExecuteAndExtractString(L"", 51 ASSERT_TRUE(tab->ExecuteAndExtractString(L"",
52 L"domAutomationController.send(location.protocol)", &out)); 52 L"domAutomationController.send(location.protocol)", &out));
53 ASSERT_EQ(L"chrome-extension:", out); 53 ASSERT_EQ(L"chrome-extension:", out);
54 ASSERT_TRUE(tab->ExecuteAndExtractString(L"", 54 ASSERT_TRUE(tab->ExecuteAndExtractString(L"",
55 L"domAutomationController.send(location.pathname)", &out)); 55 L"domAutomationController.send(location.pathname)", &out));
56 ASSERT_EQ(L"/main.html", out); 56 ASSERT_EQ(L"/main.html", out);
57 } 57 }
58 }; 58 };
59 59
60 TEST_F(BookmarksUITest, ShouldRedirectToExtension) { 60 // http://code.google.com/p/chromium/issues/detail?id=39532
61 TEST_F(BookmarksUITest, FLAKY_ShouldRedirectToExtension) {
61 scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0)); 62 scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
62 ASSERT_TRUE(browser.get()); 63 ASSERT_TRUE(browser.get());
63 64
64 int tab_count = -1; 65 int tab_count = -1;
65 ASSERT_TRUE(browser->GetTabCount(&tab_count)); 66 ASSERT_TRUE(browser->GetTabCount(&tab_count));
66 ASSERT_EQ(1, tab_count); 67 ASSERT_EQ(1, tab_count);
67 68
68 // Navigate to chrome 69 // Navigate to chrome
69 scoped_refptr<TabProxy> tab = browser->GetActiveTab(); 70 scoped_refptr<TabProxy> tab = browser->GetActiveTab();
70 ASSERT_TRUE(tab.get()); 71 ASSERT_TRUE(tab.get());
(...skipping 25 matching lines...) Expand all
96 97
97 ASSERT_TRUE(WaitForBookmarksUI(tab)); 98 ASSERT_TRUE(WaitForBookmarksUI(tab));
98 99
99 AssertIsBookmarksPage(tab); 100 AssertIsBookmarksPage(tab);
100 } 101 }
101 102
102 TEST_F(BookmarksUITest, BookmarksLoaded) { 103 TEST_F(BookmarksUITest, BookmarksLoaded) {
103 scoped_refptr<TabProxy> tab = GetBookmarksUITab(); 104 scoped_refptr<TabProxy> tab = GetBookmarksUITab();
104 ASSERT_TRUE(tab.get()); 105 ASSERT_TRUE(tab.get());
105 } 106 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698