Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: chrome/browser/cocoa/toolbar_controller.mm

Issue 1418003: [Mac] Enables drag N' drop for the buttons within the Browser Actions contain... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/extensions/browser_actions_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/toolbar_controller.mm
===================================================================
--- chrome/browser/cocoa/toolbar_controller.mm (revision 42818)
+++ chrome/browser/cocoa/toolbar_controller.mm (working copy)
@@ -639,9 +639,10 @@
name:NSWindowDidBecomeKeyNotification
object:[[self view] window]];
}
-
- CGFloat dX = NSWidth([browserActionsContainerView_ frame]) * -1;
- [self adjustLocationAndGoPositionsBy:dX animate:NO];
+ CGFloat containerWidth = [browserActionsContainerView_ isHidden] ? 0.0 :
+ NSWidth([browserActionsContainerView_ frame]);
+ if (containerWidth > 0.0)
+ [self adjustLocationAndGoPositionsBy:(containerWidth * -1) animate:NO];
BOOL rightBorderShown = !([pageButton_ isHidden] && [wrenchButton_ isHidden]);
[browserActionsContainerView_ setRightBorderShown:rightBorderShown];
}
@@ -674,13 +675,18 @@
}
- (void)pinGoButtonToLeftOfBrowserActionsContainerAndAnimate:(BOOL)animate {
- NSRect goFrame = [goButton_ frame];
- NSRect containerFrame = animate ?
- [browserActionsContainerView_ animationEndFrame] :
- [browserActionsContainerView_ frame];
+ CGFloat goXPos = [goButton_ frame].origin.x + NSWidth([goButton_ frame]);
+ CGFloat leftPadding;
- CGFloat leftPadding = containerFrame.origin.x -
- (goFrame.origin.x + NSWidth(goFrame));
+ if ([browserActionsContainerView_ isHidden]) {
+ leftPadding = NSWidth([[goButton_ window] frame]) - goXPos;
+ } else {
+ NSRect containerFrame = animate ?
+ [browserActionsContainerView_ animationEndFrame] :
+ [browserActionsContainerView_ frame];
+
+ leftPadding = containerFrame.origin.x - goXPos;
+ }
if (leftPadding != kBrowserActionsContainerLeftPadding) {
CGFloat dX = leftPadding - kBrowserActionsContainerLeftPadding;
[self adjustLocationAndGoPositionsBy:dX animate:animate];
« no previous file with comments | « chrome/browser/cocoa/extensions/browser_actions_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698