Add a small utility for dumping the system clipboard's contents on GTK.

Add a small utility for dumping the system clipboard's contents on GTK.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7562

[Evan Stade, 2008-12-17 00:06:02]

something you guys might be interested.

(I'm not really sure this is the right place to put it.)

[tony, 2008-12-17 00:48:10]

2 choices:

1) Put it in src/tools/gtk_clipboard_dump and get it to compile using the real
SCons build system (i.e., the same set of scons file that we use to build
chrome).
2) Put it in src/third_party/gtk_clipboard_dump and get it to compile using a
checked in SConscript file.

We use (2) for the image fuzzer, but I think (1) is the cleaner solution (easier
for everyone to use).

On 2008/12/17 00:06:02, Evan Stade wrote:
> something you guys might be interested.
> 
> (I'm not really sure this is the right place to put it.)

[jam, 2008-12-17 01:57:01]

there are a bunch of lint errors for dump_cb_gtk.cc...

[Evan Stade, 2008-12-17 02:00:55]

On 2008/12/17 01:57:01, John Abd-El-Malek wrote:
> there are a bunch of lint errors for dump_cb_gtk.cc...

right, this is far from being ready to submit. If I get around to doing what
Tony said then I will make it conform to google coding standards.

[Evan Stade, 2008-12-30 02:16:13]

builds with scons now

[tony, 2009-01-05 20:34:01]

LGTM, just some nits.

http://codereview.chromium.org/14175/diff/605/606
File build/SConscript.main (right):

http://codereview.chromium.org/14175/diff/605/606#newcode139
Line 139: GCD_DIR               = '$TOOLS_DIR/gtk_clipboard_dump',
Nit: I would prefer a longer and more descriptive name here, but it's not a big
deal.

http://codereview.chromium.org/14175/diff/605/607
File tools/gtk_clipboard_dump/gcd.scons (right):

http://codereview.chromium.org/14175/diff/605/607#newcode4
Line 4: Return()
Does this run on osx?  Perhaps this should be !env.Bit('linux').

http://codereview.chromium.org/14175/diff/605/607#newcode18
Line 18: env.ChromeProgram('gtk_clipboard_dump', input_files)
Do you need a call to env.Install that copies the file from opt/dbg to Hammer?

http://codereview.chromium.org/14175/diff/605/608
File tools/gtk_clipboard_dump/gtk_clipboard_dump.cc (right):

http://codereview.chromium.org/14175/diff/605/608#newcode1
Line 1: #include <gtk/gtk.h>
Nit: Needs a copyright block.

[Evan Stade, 2009-01-05 22:08:01]

http://codereview.chromium.org/14175/diff/605/607
File tools/gtk_clipboard_dump/gcd.scons (right):

http://codereview.chromium.org/14175/diff/605/607#newcode4
Line 4: Return()
On 2009/01/05 20:34:01, tony wrote:
> Does this run on osx?  Perhaps this should be !env.Bit('linux').

Done.

http://codereview.chromium.org/14175/diff/605/607#newcode18
Line 18: env.ChromeProgram('gtk_clipboard_dump', input_files)
On 2009/01/05 20:34:01, tony wrote:
> Do you need a call to env.Install that copies the file from opt/dbg to Hammer?

apparently not

http://codereview.chromium.org/14175/diff/605/608
File tools/gtk_clipboard_dump/gtk_clipboard_dump.cc (right):

http://codereview.chromium.org/14175/diff/605/608#newcode1
Line 1: #include <gtk/gtk.h>
On 2009/01/05 20:34:01, tony wrote:
> Nit: Needs a copyright block.

Done.