Issue 14172: Makes the tab restore service contain any windows that were open at...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14172: Makes the tab restore service contain any windows that were open at... (Closed)

Created:
12 years ago by sky

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Makes the tab restore service contain any windows that were open at the time of a crash. BUG=5465 TEST=Bring up chrome, go to google.com. Wait a minute. Kill chrome via the task manager. Launch chrome again. Make sure the new tab page shows an entry named 'Window (g)' where g is Google's favicon. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7188

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+366 lines, -37 lines)			Patch
M	chrome/browser/profile.h	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/sessions/session_restore.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sessions/tab_restore_service.h	View	1	5 chunks	+61 lines, -6 lines	0 comments	Download
M	chrome/browser/sessions/tab_restore_service.cc	View	1	9 chunks	+124 lines, -24 lines	0 comments	Download
M	chrome/browser/sessions/tab_restore_service_unittest.cc	View	1	2 chunks	+144 lines, -0 lines	0 comments	Download
M	chrome/test/testing_profile.h	View	1	5 chunks	+16 lines, -3 lines	0 comments	Download
M	chrome/test/testing_profile.cc	View	1	2 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

12 years ago (2008-12-17 22:24:03 UTC) #2

LGTM

http://codereview.chromium.org/14172/diff/1/8
File chrome/browser/profile.h (right):

http://codereview.chromium.org/14172/diff/1/8#newcode237
Line 237: bool restored_last_session() const { return restored_last_session_; }
I'd prefer this to be consistent with the above function (so put the code on the
next line).

http://codereview.chromium.org/14172/diff/1/7
File chrome/browser/sessions/tab_restore_service.cc (right):

http://codereview.chromium.org/14172/diff/1/7#newcode252
Line 252: if (!profile()->restored_last_session() &&
I asked about this in person. Can you label this section with a comment about
getting previously opened tabs from crashed sessions to appear in the list, and
the ScheduleGetLastSessionCommands below with something about getting the
manually closed tabs from the last session?

Expand Messages | Collapse Messages