Issue 14169: Classify V8 failures. One just needed rebaseling, the others are serious.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14169: Classify V8 failures. One just needed rebaseling, the others are serious. (Closed)

Created:
12 years ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Classify V8 failures. One just needed rebaseling, the others are serious. (V8's error message is different than JSCs.)

Patch Set 1 #

Total comments: 1

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -1 line)			Patch
A	webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/delete-getters-setters-expected.txt	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/delete-getters-setters-expected.txt	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	webkit/tools/layout_tests/test_lists/tests_fixable.txt	View	1 chunk	+6 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

12 years ago (2008-12-16 21:43:48 UTC) #2

LGTM

http://codereview.chromium.org/14169/diff/1/4
File webkit/tools/layout_tests/test_lists/tests_fixable.txt (right):

http://codereview.chromium.org/14169/diff/1/4#newcode552
Line 552: // V8 completely fails to parse the JS at all; suspect its because of
the
s/its/it's/

Expand Messages | Collapse Messages