Issue 14161: Rewrite the GKURL unit tests to not use the "old" KURL as a baseline. This is...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14161: Rewrite the GKURL unit tests to not use the "old" KURL as a baseline. This is... (Closed)

Created:
12 years ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Rewrite the GKURL unit tests to not use the "old" KURL as a baseline. This is necessary for the KURL.h refactor since it's becoming more and more difficult to do my hack where the old types are defined to a different name. This also adds deep copy to GKURL. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7089

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+253 lines, -234 lines)			Patch
	M	webkit/port/platform/GKURL.cpp	View		2 chunks	+12 lines, -3 lines	0 comments	Download
	M	webkit/port/platform/GKURL_unittest.cpp	View		14 chunks	+241 lines, -231 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages