Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 14141: Disk cache: remove the hard coded list from rankings.cc... (Closed)

Created:
12 years ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Disk cache: remove the hard coded list from rankings.cc The rankings module now works with any list, not just the first one. This is part of the support needed for new eviction algorithms. note: Rankings::CheckList() is basically the code that was implementing the old Rankings::SelfCheck() (moved with this cl). The disk cache behavior is not changing with this cl. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7074

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -142 lines) Patch
M net/disk_cache/addr.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/backend_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/backend_impl.cc View 6 chunks +13 lines, -10 lines 0 comments Download
M net/disk_cache/entry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/rankings.h View 6 chunks +31 lines, -15 lines 0 comments Download
M net/disk_cache/rankings.cc View 1 18 chunks +156 lines, -115 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rvargas (doing something else)
12 years ago (2008-12-16 00:07:32 UTC) #1
Nicolas Sylvain
lgtm http://codereview.chromium.org/14141/diff/1/4 File net/disk_cache/rankings.cc (right): http://codereview.chromium.org/14141/diff/1/4#newcode648 Line 648: return ERR_INVALID_TAIL; when head is not initialized, ...
12 years ago (2008-12-16 16:25:16 UTC) #2
rvargas (doing something else)
12 years ago (2008-12-16 19:16:26 UTC) #3
Fixed,

Thanks.

On 2008/12/16 16:25:16, Nicolas Sylvain wrote:
> lgtm
> 
> http://codereview.chromium.org/14141/diff/1/4
> File net/disk_cache/rankings.cc (right):
> 
> http://codereview.chromium.org/14141/diff/1/4#newcode648
> Line 648: return ERR_INVALID_TAIL;
> when head is not initialized, it's invalid tail, while when tail is not
> initialized it's invalid head. Maybe a comment would be useful here.

Powered by Google App Engine
This is Rietveld 408576698