Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5640)

Unified Diff: chrome/test/ui/ui_test.cc

Issue 14130: Add a ui test to make sure the Find box does not go away on Reload but does... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/ui/ui_test.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ui/ui_test.cc
===================================================================
--- chrome/test/ui/ui_test.cc (revision 6698)
+++ chrome/test/ui/ui_test.cc (working copy)
@@ -389,14 +389,15 @@
return false;
}
-bool UITest::WaitForFindWindowFullyVisible(TabProxy* tab) {
+bool UITest::WaitForFindWindowVisibilityChange(TabProxy* tab,
+ bool wait_for_open) {
const int kCycles = 20;
for (int i = 0; i < kCycles; i++) {
bool visible = false;
if (!tab->IsFindWindowFullyVisible(&visible))
return false; // Some error.
- if (visible)
- return true; // Find window is visible.
+ if (visible == wait_for_open)
+ return true; // Find window visibility change complete.
// Give it a chance to catch up.
Sleep(kWaitForActionMaxMsec / kCycles);
« no previous file with comments | « chrome/test/ui/ui_test.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698