Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 14130: Add a ui test to make sure the Find box does not go away on Reload but does... (Closed)

Created:
12 years ago by Finnur
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add a ui test to make sure the Find box does not go away on Reload but does go away when you navigate to a new page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -8 lines) Patch
M chrome/browser/views/find_bar_win_uitest.cc View 2 chunks +26 lines, -1 line 0 comments Download
M chrome/test/ui/ui_test.h View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Finnur
12 years ago (2008-12-15 23:26:55 UTC) #1
Ben, please review the following changelist.

Also, now that you have a change in-flight to return the ordinal 
on FindNext can you add the following three lines to the UI test
of that changelist:

// Negative test for the ordinal (make sure we show 0 of 0).
EXPECT_EQ(0, tab->FindInPage(L"z", FWD, IGNORE_CASE, true, &ordinal));
EXPECT_EQ(0, ordinal);

Put it at the bottom of both of these:

TEST_F(FindInPageControllerTest, FindInPageOrdinal)
TEST_F(FindInPageControllerTest, FindInPageMultiFramesOrdinal)

I was planning on writing more tests than these two (like to test
that F3 should work after you close the Find box or to test that
when you close and reopen the box that it should prepopulate the
text with the last search term), but we need some additional
functionality to capture what the box contains when opened and 
since you are changing all that it might make sense to wait until
the dust settles.

Powered by Google App Engine
This is Rietveld 408576698